Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adjust workflow and case for recent change #109

Closed
wants to merge 2 commits into from
Closed

test: adjust workflow and case for recent change #109

wants to merge 2 commits into from

Conversation

intelzhongjie
Copy link
Contributor

No description provided.

@intelzhongjie
test: adjust workflow and case for recent change
431e0e8 
Signed-off-by: zhongjie <zhongjie.shi@intel.com>
@intelzhongjie
Copy link
Contributor Author

Please @hairongchen and @Ruoyu-y review this. Thanks!

@intelzhongjie
Copy link
Contributor Author

The change here is just some effort to keep the current project healthy that it passed all the checks.
Later, we could double check the vmsdk folder and remove it with all related files update (workflow, README, etc.)

hairongchen
hairongchen approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@hairongchen hairongchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ruoyu-y
Copy link
Member

Ruoyu-y commented Mar 5, 2024

I have different ideas on this. Since vmsdk is now maintained in the other repo. We shall not run tests based on the local vmsdk source code, as a lot of changes have not been synced to this local one. And our next plan would be removing this vmsdk folder from the repo.

@Ruoyu-y
Copy link
Member

Ruoyu-y commented Mar 5, 2024

So it might be more reasonable to clone the vmsdk from the other repo in the workflow file and run the test.

@intelzhongjie
Copy link
Contributor Author

Thanks for Hairong's review!
After discussion with Ruoyu, I'll take some more effort to update this with vmsdk subfolder removed. Thanks!

@intelzhongjie intelzhongjie force-pushed the main branch 3 times, most recently from fe9e590 to afad410 Compare March 6, 2024 07:44
@intelzhongjie
remove the folder "vmsdk"
b951576 
The latest code for vmsdk can be found here:
https://github.com/cc-api/cc-trusted-vmsdk/tree/main

Signed-off-by: zhongjie <zhongjie.shi@intel.com>
@intelzhongjie
Copy link
Contributor Author

I'll post another PR to remove the vmsdk to resolve the issues mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairongchen hairongchen hairongchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@intelzhongjie @Ruoyu-y @hairongchen