CI: Revert breaking change to valgrind test

[elykwilliams]

Revert breaking change to valgrind CI test

It looks like the Valgrind test will need some updating before bumping the OS to Ubuntu 24.04. I'm not sure why but as the logs show, it's failing to successfully install the system packages. Related to #185. Breaking Commit was 0c3a681.

Proposed changes:
I've reverted the OS to Ubuntu 22.04 for the valgrind test, until I can give it a closer look #191 .

[cburstedde]

Thanks, is there anything we can do about the faliing test on Mac with gcc 13?

[elykwilliams]

Thanks, is there anything we can do about the faliing test on Mac with gcc 13?

I'm looking into it. It's strange because the bump to gcc-13 happened back in December, so that by itself isnt the problem. But the issue seems to be that cmake isn't finding a compatible version of mpi, even though it is finding the homebrew installed open-mpi.

[cburstedde]

Maybe @scivision can help.

As soon as possible, I'd like to establish to only use software (like valgrind and CMake) no newer than what's in the current Debian stable distribution. For CMake that's 3.25.

[cburstedde]

Should I just merge this one since it CI checks fine? Ah wait, the MacOS gcc13 test is the issue.

[cburstedde]

Maybe @scivision can help.

As soon as possible, I'd like to establish to only use software (like valgrind and CMake) no newer than what's in the current Debian stable distribution. For CMake that's 3.25.

That would also mean using at most gcc-11. Would anything speak against this policy, specifically for p4est and sc?

[cburstedde]

I'm also wondering about specifying CC= in the CI CMake. With MPI, the compiler should always be mpicc -- is this silently added by the CMake MPI logic, or do we need to do something about it?

[scivision]

I think this PR can be closed; this was a transient issue in the new Ubuntu 24.04 image.
#194 shows Valgrind working with Ubuntu 24.04

[cburstedde]

I think this PR can be closed; this was a transient issue in the new Ubuntu 24.04 image. #194 shows Valgrind working with Ubuntu 24.04

Ok closing here. Thanks for the report/initiative @elykwilliams !