Phrase share button feature. #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b86714e to
3b19f1b
Compare
martinbedouret
requested changes
May 26, 2021
src/components/Board/Output/PhraseShare/PhraseShare.component.js
Outdated
Show resolved
Hide resolved
src/components/Board/Output/PhraseShare/PhraseShare.component.js
Outdated
Show resolved
Hide resolved
src/components/Board/Output/PhraseShare/PhraseShare.component.js
Outdated
Show resolved
Hide resolved
src/components/Board/Output/PhraseShare/PhraseShare.component.js
Outdated
Show resolved
Hide resolved
src/components/Board/Output/PhraseShare/PhraseShare.component.js
Outdated
Show resolved
Hide resolved
resolve conflict variables and props names, add twitter hashtags. add subject message. prevent map error
martinbedouret
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an optional Share button on the Output component. This allows sharing on social media the labels of the symbols on the 'output' like a Phrase. You can activate this on Settings/Navigation and Buttons.
The problem right now is that this functionality is mainly to share URL content. This causes that Facebook and Reddit require a URL like a prop. We can pass the Cboard.io link but the phrase is shared only like a quote and no like a comment.
sorry that I have my Facebook in Spanish.