-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/create-remote-Board-on-update-LoadBoards #1703
Merged
tomivm
merged 16 commits into
cboard-org:master
from
tomivm:fix/create-remote-Board-on-update-LoadBoards
Jul 3, 2024
Merged
Fix/create-remote-Board-on-update-LoadBoards #1703
tomivm
merged 16 commits into
cboard-org:master
from
tomivm:fix/create-remote-Board-on-update-LoadBoards
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo - use intl to translateName
…te-Board-on-update-LoadBoards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1690
Posting every default board that uses a newly created API board id as loadBoard. To avoid losing boards between devices and logouts.
This ensures navigations between folders are using the loadBoard IDs and avoids navigating comparing the folder label and the Board Names. See https://github.com/tomivm/cboard/blob/d9943f82c3da4bb7e45f9c821588bebfe0b1569e/src/components/Board/Board.container.js#L888
This refactors pieces of two of our main functions. Please do a strong test.
Check how boards are updated and created.
Take care that the data on the Redux store and the data on the DB should be equal. Also, check if all the loadBoards IDs that should point to a remote board are correctly updated on our DB and in the local storage.