Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toggle password visibility #1700

Merged
merged 4 commits into from
May 26, 2024
Merged

toggle password visibility #1700

merged 4 commits into from
May 26, 2024

Conversation

nmro184
Copy link
Contributor

@nmro184 nmro184 commented May 24, 2024

resolving #1354

RodriSanchez1
RodriSanchez1 requested changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error on the console TextField.js:43 Warning: Failed prop type: The prop children is marked as required in ForwardRef(InputAdornment), but its value is null.

Let me know if you have some doubts!!

@nmro184
Copy link
Contributor Author

nmro184 commented May 24, 2024

thanks for the comments , when I run it locally I didn't get that warning , committed the changes you suggested.

@nmro184 nmro184 requested a review from RodriSanchez1 May 24, 2024 16:38
@nmro184
Copy link
Contributor Author

nmro184 commented May 25, 2024

@RodriSanchez1 hey I see the changes requested tag is still present. Is there anything else that needs to be fixed?

RodriSanchez1
RodriSanchez1 approved these changes May 26, 2024
View reviewed changes
Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!!! Thanks!

@RodriSanchez1 RodriSanchez1 merged commit aa67328 into cboard-org:master May 26, 2024
5 checks passed
@tomivm tomivm mentioned this pull request May 27, 2024
Closed
@RodriSanchez1 RodriSanchez1 linked an issue May 27, 2024 that may be closed by this pull request
Toggle password visibility #1354
Closed
@RodriSanchez1 RodriSanchez1 mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayc shayc shayc left review comments

@RodriSanchez1 RodriSanchez1 RodriSanchez1 approved these changes

Assignees

@nmro184 nmro184

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toggle password visibility
3 participants
@nmro184 @shayc @RodriSanchez1