Fix/play ogg audio on Safari #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| playAudio(src) { | ||
| let audio = new Audio(); | ||
| async playAudio(src) { | ||
| const safariNeedHelp = IS_BROWSING_FROM_SAFARI && src.endsWith('.ogg'); |
RodriSanchez1
approved these changes
Jul 5, 2023
|
LGTM |
RodriSanchez1
requested changes
Jul 5, 2023
|
@RodriSanchez1 Should ignore the files added for support ogv.js. I can't do it from my account. |
martinbedouret
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works but audio are not cached
close #1499