Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / default boards options mananger #1324

Merged
merged 47 commits into from
Dec 26, 2022
Merged

Feature / default boards options mananger #1324

merged 47 commits into from
Dec 26, 2022

Conversation

tomivm
Copy link
Collaborator

@tomivm tomivm commented Dec 19, 2022

No description provided.

tomivm added 20 commits December 7, 2022 17:27
@tomivm
Add DefaultBoard Selector
de4c79f
@tomivm
Implement confirmation dialog before change default board
480120b
@tomivm
Change card styles
42033f5
@tomivm
Update Snapshots
e987ce5
@tomivm
Implement state to store defaultBoards that are already included
c95c8de
@tomivm
Create a action to change between defaults boards
c69c93a
@tomivm
Include new default board on the initial value for boards state
8e6c514
@tomivm
Use action to change default board on DefaultBoardSelector
3d691dc
@tomivm
Rename switchBoard function to switch Active Board on changeDefaultBoard
6e02f25
@tomivm
Manage home board id replace on default boards
e965d66
@tomivm
remove the default boards data from initial state.
3ec836c
@tomivm
implement fallback if default boards included is null.
98700ae
@tomivm
get defaultBoardsIncluded from active communicator
dcf923c
@tomivm
Migrate the defaultBoardsIncluded property to the communicator state.
30d0243
@tomivm
Fix the returned type on fallback for defaultBoardsIncluded
d4e6a81
@tomivm
fix to get defaultBoardsIncluded from active communicator
deae166
@tomivm
Include the new boards on default state using migrations
44005f6
@tomivm
Merge branch 'master' into feature/default-boards-options-mananger
1f1f1cc
@tomivm
change board migrate version to 0
7a7813b
@tomivm
Use default boards from helper
7c18830
@RodriSanchez1
Copy link
Collaborator

Needs to add the prop defaultBoardIncluded on the intitial state of the communicator reducer

@tomivm
Copy link
Collaborator Author

tomivm commented Dec 21, 2022

Needs to add the prop defaultBoardIncluded on the intitial state of the communicator reducer

@RodriSanchez1 Are you sure that this is necessary? in principle this is intentional because the feature is designed to support old users. If the user not has default boards included and uses the feature. The communicator home board (that probably is already modified) is stored for the 'advanced' homeBoard.
Do you think that this could cause a bug?

@tomivm tomivm marked this pull request as ready for review December 21, 2022 16:14
@tomivm
Copy link
Collaborator Author

tomivm commented Dec 22, 2022

To improve the first usage of the app the default boards gallery should be integrated into the first dialog of the boardTour
image

martinbedouret
martinbedouret requested changes Dec 22, 2022
View reviewed changes
@martinbedouret martinbedouret merged commit 4c44eee into cboard-org:master Dec 26, 2022
@martinbedouret martinbedouret added this to the 1.25.0 milestone Dec 26, 2022
@martinbedouret martinbedouret linked an issue Dec 26, 2022 that may be closed by this pull request
Add a new core board based on the Picseepal 11x6 using ARASAAC symbols #1311
Closed
@tomivm tomivm deleted the feature/default-boards-options-mananger branch January 13, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodriSanchez1 RodriSanchez1 RodriSanchez1 left review comments

@martinbedouret martinbedouret martinbedouret approved these changes

Assignees
No one assigned
Labels
Ceibal
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Add a new core board based on the Picseepal 11x6 using ARASAAC symbols
3 participants
@tomivm @RodriSanchez1 @martinbedouret