Correct differentiation between local and cloud voices #1176
+30
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbedouret
requested changes
May 4, 2022
martinbedouret
approved these changes
Dec 27, 2022
RodriSanchez1
pushed a commit
that referenced
this pull request
Dec 30, 2022
…ource" This reverts commit b5ef1d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr the classification of online and local voices has been corrected.
We get the localService property to differentiate if the voice is installed on the device or not.
As issue #1052 indicates, we were treating the voices provided by the browser as local, when in fact they were online.
For android, the cboard-speech-tts plugin has been modified to obtain the feature property that tells us if the voice provided by android.tts.speech is installed on the device. In order to test this update in cordova, first you have to delete the cboard-speech-tts plugin and modify the package.json and package-lock.json files by changing the path of said plugin to
"cboard-speech-tts": "github:RodriSanchez1/cboard-speech-tts#fix/localVoices "on ccboard repository.close #1052