Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add title_bar.inactive_background styles #26

Merged
merged 4 commits into from
Jul 26, 2024
Merged

add title_bar.inactive_background styles #26

merged 4 commits into from
Jul 26, 2024

Conversation

tepavcevic
Copy link
Contributor

#25

@tepavcevic
Copy link
Contributor Author

tepavcevic commented Jul 25, 2024

Hey @tecandrew,
can you give me a hand with this formatting issue I'm having? I just tried adding titlebar inactive color, but for some reason I couldn't get neither zed nor vscode to respect editorconfig. This PR should have been 8 lines instead of entire files with 3k+ total LOC.

@AlvaroParker
Copy link

AlvaroParker commented Jul 26, 2024

@tepavcevic on zed try disabling format on save on the config file "format_on_save": "off" or just add it using vim or nano if it's just one line.
Edit: You can also disable it only for json:

    "JSON": {
      "format_on_save": "off"
    }

@tecandrew
Copy link
Collaborator

tecandrew commented Jul 26, 2024

@tepavcevic we don't modify the generated JSON files directly since we also generate all flavors' accents in each release for those who would like to override the default "mauve" accent

"icon.accent": "#8839ef",
"status_bar.background": "#dce0e8",
"title_bar.background": "#dce0e8",
"title_bar.inactive_background": "#dce0e8",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping the color as catppuccin's "crust" color makes sense. to make the "inactive" state obvious, maybe we can keep some of the "transparent" coloring a bit, but not so transparent since that seems to be the fallback behavior

image

@tecandrew
Copy link
Collaborator

tecandrew commented Jul 26, 2024

added blur, but I'm not sure it works on Linux yet. it may on MacOS?

slight transparency seems to look OK 😄

image

image

image

image

edit: seems to do nothing on MacOS. will keep it in there for future possible blur or transparency stuff just in case 🤷

image image

@tepavcevic
Copy link
Contributor Author

tepavcevic commented Jul 26, 2024

Thanks for the tip @AlvaroParker.
@tecandrew I wasn't familiar with how setting up the theme goes, I'm glad you were eager to jump in and help.
I tested it on ubuntu and it looks really nice 😄
Screenshot from 2024-07-26 09-09-01
Screenshot from 2024-07-26 09-13-47
Screenshot from 2024-07-26 09-14-19
Screenshot from 2024-07-26 09-14-49

@tecandrew tecandrew merged commit d4990b9 into catppuccin:main Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants