Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated scrollbar_thumb.background with scrollbar.thumb.background #23

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

injust
Copy link
Contributor

@injust injust commented Jul 20, 2024

From Zed logs:

[WARN] Theme "Catppuccin Latte" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[WARN] Theme "Catppuccin Frappé" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[WARN] Theme "Catppuccin Macchiato" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.
[WARN] Theme "Catppuccin Mocha" is using a deprecated style property: scrollbar_thumb.background. Use `scrollbar.thumb.background` instead.

@injust
Copy link
Contributor Author

injust commented Jul 20, 2024

Tested by installing dev extension. No noticeable changes but the warning disappeared from the log.

@tecandrew
Copy link
Collaborator

nice! lgtm. thanks for doing this. haven't been too aware of their schema changes

i'll merge this and your other one and bump the version this weekend. all other accent flavors need to be regenerated for the GH release

@tecandrew tecandrew merged commit f348e2f into catppuccin:main Jul 21, 2024
@injust injust deleted the patch-1 branch July 21, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants