Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check): wait until all diffs are shown before exiting #53

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

sgoudham
Copy link
Contributor

Currently, the --check command exits after the first invocation of the difftool which means that diffs for multiple files are not shown, which is an error for ports that generate multiple files:

You can see this behaviour in action below where 2 files have been edited but only one diff is shown:
image

This PR updates the implementation of the check command to wait till after all the diffs are shown and only exit afterwards.

Now, you can see that it works as expected:

image

I'm going to see a movie with a friend soon so just quickly mocked this up, feel more than free to edit the PR and optimise it more since I don't write much Rust these days. (I imagine we can move away from using a Vec)

@sgoudham sgoudham requested a review from backwardspy October 12, 2024 08:55
Copy link
Member

@backwardspy backwardspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

render_single_output needs to exit on CheckResult::Fail too

@sgoudham sgoudham requested a review from backwardspy October 12, 2024 09:11
@backwardspy backwardspy merged commit 66d6ffe into main Oct 12, 2024
6 checks passed
@backwardspy backwardspy deleted the fix/early-exit-for-check-command branch October 12, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants