fix(check): wait until all diffs are shown before exiting #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
--check
command exits after the first invocation of the difftool which means that diffs for multiple files are not shown, which is an error for ports that generate multiple files:You can see this behaviour in action below where 2 files have been edited but only one diff is shown:
This PR updates the implementation of the check command to wait till after all the diffs are shown and only exit afterwards.
Now, you can see that it works as expected:
I'm going to see a movie with a friend soon so just quickly mocked this up, feel more than free to edit the PR and optimise it more since I don't write much Rust these days. (I imagine we can move away from using a
Vec
)