Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(whiskers): write results to filename in single file mode #218

Merged
merged 5 commits into from
May 23, 2024
Merged

feat(whiskers): write results to filename in single file mode #218

merged 5 commits into from
May 23, 2024

Conversation

uncenter
Copy link
Member

Now writes the results of single file templates to whiskers.filename if present, like in matrix mode.

@uncenter uncenter changed the title feat: write results to filename in single file mode feat(whiskers): write results to filename in single file mode May 16, 2024
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be good to update the justfiles in the single-file directory as part of this PR.

@uncenter uncenter requested a review from sgoudham May 18, 2024 01:54
whiskers/src/main.rs Outdated Show resolved Hide resolved
whiskers/src/main.rs Outdated Show resolved Hide resolved
@uncenter uncenter requested review from nullishamy and sgoudham May 19, 2024 21:29
Copy link
Contributor

@nullishamy nullishamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to have conflicts? Can get those fixed and then this is good for merge 👍

@uncenter
Copy link
Member Author

Ah yeah it was the trailing newlines I fixed in my last PR. Should be good now.

@uncenter uncenter requested a review from nullishamy May 22, 2024 15:55
@nullishamy nullishamy requested a review from backwardspy May 22, 2024 16:41
@sgoudham sgoudham merged commit 4715155 into catppuccin:main May 23, 2024
6 checks passed
@uncenter uncenter deleted the feat/filename-single-file branch May 23, 2024 16:36
@github-actions github-actions bot mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants