Prevent infinity loop when 'particleCount' is negative number. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d38u6
commented
Oct 15, 2020
Comment on lines
+209
to
+212
| function onlyPositiveInt(number){ | ||
| return number < 0 ? 0 : Math.floor(number); | ||
| } | ||
|
|
There was a problem hiding this comment.
add 'onlyPositiveInt' transform function
d38u6
commented
Oct 15, 2020
| @@ -412,7 +416,7 @@ | |||
| var animationObj; | |||
|
|
|||
| function fireLocal(options, size, done) { | |||
| var particleCount = prop(options, 'particleCount', Math.floor); | |||
| var particleCount = prop(options, 'particleCount', onlyPositiveInt); | |||
There was a problem hiding this comment.
use 'onlyPositiveInt' function instead Math.floor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'particleCount' is negative number, while loop in this line
var temp = particleCount; while (temp--)it becomes infinite. So I suggest create only positive integer transform function and pass it instead Math.floor.