fixed inconsistent semicolon expansion in catch_discover_tests (Bug #2214) #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could it be that the clang-8 build environment is broken? The build checks say they cannot find clang++-8. Or am I doing something wrong? |
Codecov Report
@@ Coverage Diff @@
## devel #2215 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 146 146
Lines 7103 7103
=======================================
Hits 6397 6397
Misses 706 706 |
|
Yeah, GitHub actions recently changed the base linux image, and I haven't had time to fix it up yet. Given that contrib is currently not tested, there is no way for the failures to be result of your PR. |
horenmar
reviewed
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the parameter parsing in the function
add_commandinCatchAddTests.cmakeso that parameters that contain semicolons are not split into several arguments in the generated*_tests.cmakefile. This fixes broken tests for targets whose cross-compiling generators contain arguments with escaped semicolons.GitHub Issues
Closes #2214