The output of --list-* flags obeys -o flag #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, every base derived from the IStreamingReporter had its own `IConfig const* m_config` member, so this just centralizes the handling thereof. Part of #2061
The previous commit made it so that the `IConfig` is stored in `IStreamingReporter` and thus always available.
Also generalized the implementations to write to the provided output stream, which will be required for the follow up changes, where the listings should happen to the location user asked for by specifying the `-o` flag.
Also added tests for the default implementations of list* reporter helpers. Closes #2061
Codecov Report
@@ Coverage Diff @@
## devel #2163 +/- ##
==========================================
+ Coverage 90.03% 90.07% +0.04%
==========================================
Files 146 146
Lines 7089 7110 +21
==========================================
+ Hits 6382 6404 +22
+ Misses 707 706 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes behaviour of
--list-*flags so that if output target is provided via-oflag, the resulting listing is written to that target, rather than to stdout, like it was in v2.There is also a bunch of internal changes and refactorings to enable this feature, and to make future implementation of multiple reporters simpler.
GitHub Issues
#2061