-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mini
returns -1m instead of 1m for some locales
#49
Comments
This is the default behavior when no custom |
I could do that, but why would prepending the minus be the default behavior? Is there a good reason for it? Besides the minus everything works fine for Romanian even without the custom |
Because it's how it is defined in Unicode CLDR data in the English (no minuses): Some other language (has minuses): |
I think most languages except English have minuses defined in the CLDR. French has them too for example: However, this library is supposed to return the time ago, so it's a bit inconsistent to return a minus from it. I understand it's an upstream problem though, but it should maybe be mentioned as a caveat in the README. #50 will fix it for romanian, but this is likely to be a problem for other languages as well. |
Well, maybe. |
So I just tried this with Romanian, and it appears that
1 minute ago
returns-1m
instead of just1m
.There's the extra minus in a bunch of other styles in some places but not others. With the
en
locale everything is fine.Is the minus a bug?
The text was updated successfully, but these errors were encountered: