Fix Update Dev Version on Release Workflow #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyCBakerPhD
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The triggering workflow name for update version was incorrectly set to
auto-publish(the name of the yaml file). It should have beenUpload Package to PyPI(the name field of the workflow).No easy way to retrigger the upload package to pypi workflow -- in fact using
skip-existingis specifically recommended against by action authors: https://github.com/pypa/gh-action-pypi-publish. So, we'll just have to check if this works properly on the next release.Also, the triggered PR doesn't run the appropriate tests bc of a github actions bug with the
secrets.GITHUB_TOKEN(see stack overflow) --> so that is fixed by using my PAT -- see #308