Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fix for frames_per_slice edge case #294

Merged
merged 2 commits into from
Mar 19, 2024
Merged

added fix for frames_per_slice edge case #294

merged 2 commits into from
Mar 19, 2024

Conversation

pauladkisson
Copy link
Member

Fixes #293.

@pauladkisson
Copy link
Member Author

@weiglszonja, let me know is this PR fixes your issue.

Copy link
Contributor

@weiglszonja weiglszonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just tested it now. Thanks!

@pauladkisson pauladkisson enabled auto-merge (squash) March 19, 2024 00:13
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.35%. Comparing base (7aa2a63) to head (a0327b4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   79.37%   79.35%   -0.02%     
==========================================
  Files          39       39              
  Lines        3069     3071       +2     
==========================================
+ Hits         2436     2437       +1     
- Misses        633      634       +1     
Flag Coverage Δ
unittests 79.35% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...imagingextractors/scanimagetiffimagingextractor.py 98.46% <50.00%> (-0.50%) ⬇️

@pauladkisson pauladkisson merged commit 94691a4 into main Mar 19, 2024
16 checks passed
@pauladkisson pauladkisson deleted the scanimage branch March 19, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants