-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docs #282
Update Docs #282
Conversation
OK goal here is to get the docs to build successfully on the PR with the pydata theme |
Is there a way for me to get access to the readthedocs account associated with roiextractors? |
I'd need your RTD username |
It's pauladkisson |
Out of curiosity, are you unable to see the details from the log build without admin access? https://readthedocs.org/projects/roiextractors/builds/23351775/ |
Yeah, turns out I could see pretty much all the details without full access, I just wanted to be sure I wasn't missing anything. |
This is now successfully building the docs but throws out a bunch of (non-breaking) import errors when I build locally, so the API documentation seems like it still needs some work. Nevertheless, I think I would like to merge this PR here, and later swing back around to fix the API documentation (see #184). |
Indeed looks as if the API docs will take some work to cleanup; could you at least suppress them here so they don't show up that way on |
Done |
It might be kind of petty, but I'd prefer to have the section numbering removed - I don't think it really adds much here; what do you think? |
Ahhh, just noticed this as well on the front page
Not entirely true; perhaps change to "which is the set of pixels from acquired fluorescence images which the segmentation software has determined to follow a particular cellular structure." or something similar? Maybe @alessandratrapani can improve description even more We've seen cases in last years of ROIs being (i) glia, not neurons, (ii) dendritic branches or axon trajectories, (iii) segmentation by cell type based on morphology, (iv) edge case of considering neurotransmitter densities as the ROI of fibre photometry |
Also on main page, what are STK and FLI formats? Have I forgotten about those extractors? |
Also on main page, we don't save to NWB format with this package (which is only for reading) so I'd remove that or potentially add a cross link to NeuroConv to let people know they can use that to write to NWB |
I agree with you. I think the description it's already very good. |
Update documentation with new info previously found in the readme, and some style/CI changes.