Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs #282

Merged
merged 19 commits into from
Feb 8, 2024
Merged

Update Docs #282

merged 19 commits into from
Feb 8, 2024

Conversation

pauladkisson
Copy link
Member

Update documentation with new info previously found in the readme, and some style/CI changes.

@pauladkisson pauladkisson mentioned this pull request Feb 5, 2024
@CodyCBakerPhD
Copy link
Member

OK goal here is to get the docs to build successfully on the PR with the pydata theme

@pauladkisson
Copy link
Member Author

Is there a way for me to get access to the readthedocs account associated with roiextractors?

@CodyCBakerPhD
Copy link
Member

Is there a way for me to get access to the readthedocs account associated with roiextractors?

I'd need your RTD username

@pauladkisson
Copy link
Member Author

I'd need your RTD username

It's pauladkisson

@CodyCBakerPhD
Copy link
Member

Out of curiosity, are you unable to see the details from the log build without admin access? https://readthedocs.org/projects/roiextractors/builds/23351775/

@pauladkisson
Copy link
Member Author

Out of curiosity, are you unable to see the details from the log build without admin access? https://readthedocs.org/projects/roiextractors/builds/23351775/

Yeah, turns out I could see pretty much all the details without full access, I just wanted to be sure I wasn't missing anything.

@pauladkisson
Copy link
Member Author

pauladkisson commented Feb 5, 2024

This is now successfully building the docs but throws out a bunch of (non-breaking) import errors when I build locally, so the API documentation seems like it still needs some work. Nevertheless, I think I would like to merge this PR here, and later swing back around to fix the API documentation (see #184).

@CodyCBakerPhD
Copy link
Member

Indeed looks as if the API docs will take some work to cleanup; could you at least suppress them here so they don't show up that way on main, then polish in follow-up?

@pauladkisson
Copy link
Member Author

Indeed looks as if the API docs will take some work to cleanup; could you at least suppress them here so they don't show up that way on main, then polish in follow-up?

Done

@CodyCBakerPhD
Copy link
Member

It might be kind of petty, but I'd prefer to have the section numbering removed - I don't think it really adds much here; what do you think?

@CodyCBakerPhD
Copy link
Member

Ahhh, just noticed this as well on the front page

ROI
Stands for Region Of Interest, which is the region in a set of acquired fluorescence images which the segmentation software has determined as a neuron.

Not entirely true; perhaps change to

"which is the set of pixels from acquired fluorescence images which the segmentation software has determined to follow a particular cellular structure." or something similar? Maybe @alessandratrapani can improve description even more

We've seen cases in last years of ROIs being (i) glia, not neurons, (ii) dendritic branches or axon trajectories, (iii) segmentation by cell type based on morphology, (iv) edge case of considering neurotransmitter densities as the ROI of fibre photometry

@CodyCBakerPhD
Copy link
Member

Also on main page, what are STK and FLI formats? Have I forgotten about those extractors?

@CodyCBakerPhD
Copy link
Member

Also on main page, we don't save to NWB format with this package (which is only for reading) so I'd remove that or potentially add a cross link to NeuroConv to let people know they can use that to write to NWB

@alessandratrapani
Copy link
Collaborator

Ahhh, just noticed this as well on the front page

ROI
Stands for Region Of Interest, which is the region in a set of acquired fluorescence images which the segmentation software has determined as a neuron.

Not entirely true; perhaps change to

"which is the set of pixels from acquired fluorescence images which the segmentation software has determined to follow a particular cellular structure." or something similar? Maybe @alessandratrapani can improve description even more

We've seen cases in last years of ROIs being (i) glia, not neurons, (ii) dendritic branches or axon trajectories, (iii) segmentation by cell type based on morphology, (iv) edge case of considering neurotransmitter densities as the ROI of fibre photometry

I agree with you. I think the description it's already very good.

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) February 8, 2024 23:20
@CodyCBakerPhD CodyCBakerPhD merged commit 6f1b504 into main Feb 8, 2024
16 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the docs branch February 8, 2024 23:20
@pauladkisson pauladkisson mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants