Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override of channel_name in Suite2pSegmentationExtractor #263

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

weiglszonja
Copy link
Contributor

Fix an oversight from my side in #242 which overrides channel_name and leads to incorrect reading of the mean image.

@CodyCBakerPhD
Copy link
Member

@weiglszonja Can you think of any way to add a test for this?

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #263 (3ca299f) into main (abe24d7) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   79.01%   79.00%   -0.01%     
==========================================
  Files          39       39              
  Lines        3031     3030       -1     
==========================================
- Hits         2395     2394       -1     
  Misses        636      636              
Flag Coverage Δ
unittests 79.00% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...extractors/suite2p/suite2psegmentationextractor.py 89.54% <100.00%> (-0.07%) ⬇️

@CodyCBakerPhD CodyCBakerPhD merged commit 138a8e3 into main Nov 22, 2023
14 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_suite2p_channel_name branch November 22, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants