Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MicroManagerTiffImagingExtractor private extractor's dtype #257

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

weiglszonja
Copy link
Contributor

Fixes that the private extractors dtype should match the main extractor's dtype, and adds test to make sure not overriding it in private extractor's get_video()

@weiglszonja weiglszonja self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #257 (3d6104d) into main (8041fb0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   79.00%   79.01%   +0.01%     
==========================================
  Files          39       39              
  Lines        3029     3031       +2     
==========================================
+ Hits         2393     2395       +2     
  Misses        636      636              
Flag Coverage Δ
unittests 79.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gingextractors/micromanagertiffimagingextractor.py 98.33% <100.00%> (+0.02%) ⬆️

@CodyCBakerPhD CodyCBakerPhD merged commit f404852 into main Nov 9, 2023
15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_micromanagertiff_dtype branch November 9, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants