-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MicroManagerTiffImagingExtractor
#222
Conversation
src/roiextractors/extractors/tiffimagingextractors/micromanagertiffimagingextractor.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
…ctor' into add_MicroManagerTiffImagingExtractor
for more information, see https://pre-commit.ci
This reverts commit 2e0fe6b.
video_shape = (stop - start,) + self._imaging_extractors[0].get_image_size() | ||
video_shape = (stop - start,) + self.get_image_size() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to change this?
Since it's an abstract method wouldn't you need to also define get_image_size
generally for the MultiImagingExtractor
?
I'd prefer if you can leave the base class here unchanged and do what you need to in the child classes, is that possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, it's not necessary to change, better to keep it as is.
Overall looks good, one comment that has the potential to break back-compatibility (though I admit it's likely not being tested explicitly) |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 74.27% 75.45% +1.17%
==========================================
Files 34 35 +1
Lines 2395 2514 +119
==========================================
+ Hits 1779 1897 +118
- Misses 616 617 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Add extractor for the Micro-Manager TIF image format: