Add detector for if timestamps are set #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiglszonja
reviewed
Oct 31, 2022
weiglszonja
reviewed
Oct 31, 2022
weiglszonja
reviewed
Oct 31, 2022
Co-authored-by: Szonja Weigl <weigl.anna.szonja@hallgato.ppke.hu>
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 73.23% 73.28% +0.04%
==========================================
Files 33 33
Lines 2298 2302 +4
==========================================
+ Hits 1683 1687 +4
Misses 615 615
Flags with carried forward coverage won't be shown. Click here to find out more.
|
weiglszonja
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for fixing the new issue on catalystneuro/neuroconv#159
Follows API pattern established by SpikeInterface: https://github.com/SpikeInterface/spikeinterface/blob/master/spikeinterface/core/baserecording.py#L171-L178
Also added a new portion to the testing suite for base classes, which could be filled out more in the future