Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] SpikeGLXRecording utility and duplicated probe setting #696

Merged
merged 9 commits into from
Feb 12, 2024

Conversation

CodyCBakerPhD
Copy link
Member

@CodyCBakerPhD CodyCBakerPhD commented Dec 19, 2023

Currently supported SI version range supports automatic probe setting for SpikeGLX

Also moving a spare function to the nearby utilities to live with the other one-off functions

@CodyCBakerPhD CodyCBakerPhD self-assigned this Dec 19, 2023
@CodyCBakerPhD CodyCBakerPhD marked this pull request as draft December 19, 2023 20:25
CHANGELOG.md Outdated Show resolved Hide resolved
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review February 11, 2024 04:22
@CodyCBakerPhD CodyCBakerPhD changed the title Add metadata support for NHP SpikeGLX probes [Cleanup] SpikeGLXRecording utility and duplicated probe setting Feb 11, 2024
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the other format with everything together and no utils somehow... but this is a weak preference.

@CodyCBakerPhD
Copy link
Member Author

I prefer the other format with everything together and no utils somehow... but this is a weak preference.

That style makes it take much longer to navigate to scan through files looking for any particular interface classes you might be looking for (have to scroll down past a lot of lines at the top), which pretty much forces you to use an IDE or GitHub search functionality to navigate efficiently, which is only possible if you already know exactly what keywords to search for

That's one of my justifications for it

For the same reason I'd also like to splinter off some of the classes that are defined in the same file, such as NeuroScopeSorting at the bottom of the same file the NeuroScopeRecording is in. Simplifies the amount and diversity of content defined in a single file

As more modalities start to cross into both neural types and behavior types, it also may have been a mistake of mine to nest things by modality under the datainterfes submodule; might be better if that became flatter by only leading directly to the format name and collection of interfaces for it

All these things are noticed from the effort in #734 - what do you think?

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) February 12, 2024 16:09
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a58d05) 92.32% compared to head (6aa06c2) 92.06%.
Report is 1 commits behind head on main.

❗ Current head 6aa06c2 differs from pull request most recent head 38b58fd. Consider uploading reports for the commit 38b58fd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   92.32%   92.06%   -0.27%     
==========================================
  Files         115      115              
  Lines        6075     5960     -115     
==========================================
- Hits         5609     5487     -122     
- Misses        466      473       +7     
Flag Coverage Δ
unittests 92.06% <100.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../datainterfaces/ecephys/spikeglx/spikeglx_utils.py 97.87% <100.00%> (+0.72%) ⬆️
...terfaces/ecephys/spikeglx/spikeglxdatainterface.py 92.15% <ø> (-1.97%) ⬇️

... and 63 files with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit 4d565dc into main Feb 12, 2024
32 of 36 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the add_nhp_spikeglxX_support branch February 12, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants