-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] SpikeGLXRecording utility and duplicated probe setting #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the other format with everything together and no utils somehow... but this is a weak preference.
That style makes it take much longer to navigate to scan through files looking for any particular interface classes you might be looking for (have to scroll down past a lot of lines at the top), which pretty much forces you to use an IDE or GitHub search functionality to navigate efficiently, which is only possible if you already know exactly what keywords to search for That's one of my justifications for it For the same reason I'd also like to splinter off some of the classes that are defined in the same file, such as As more modalities start to cross into both neural types and behavior types, it also may have been a mistake of mine to nest things by modality under the All these things are noticed from the effort in #734 - what do you think? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
- Coverage 92.32% 92.06% -0.27%
==========================================
Files 115 115
Lines 6075 5960 -115
==========================================
- Hits 5609 5487 -122
- Misses 466 473 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Currently supported SI version range supports automatic probe setting for SpikeGLX
Also moving a spare function to the nearby utilities to live with the other one-off functions