-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alignment method support to mock recording interface #611
Merged
CodyCBakerPhD
merged 12 commits into
main
from
add_segments_to_mock_recording_interface
Oct 25, 2023
Merged
Add alignment method support to mock recording interface #611
CodyCBakerPhD
merged 12 commits into
main
from
add_segments_to_mock_recording_interface
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k_recording_interface' into add_segments_to_mock_recording_interface
h-mayorquin
changed the title
Add segments to mock recording interface
Add alignment method support to mock recording interface
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 91.05% 91.02% -0.04%
==========================================
Files 103 103
Lines 5313 5314 +1
==========================================
- Hits 4838 4837 -1
- Misses 475 477 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodyCBakerPhD
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for the time alignment methods to work with the mock recording interface. They are enabled through super and because this interface does not have super (maybe it should) they are not enable yet.