Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alignment method support to mock recording interface #611

Merged
merged 12 commits into from
Oct 25, 2023

Conversation

h-mayorquin
Copy link
Collaborator

This is necessary for the time alignment methods to work with the mock recording interface. They are enabled through super and because this interface does not have super (maybe it should) they are not enable yet.

@h-mayorquin h-mayorquin self-assigned this Oct 24, 2023
@h-mayorquin h-mayorquin changed the title Add segments to mock recording interface Add alignment method support to mock recording interface Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #611 (762a822) into main (88f0015) will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   91.05%   91.02%   -0.04%     
==========================================
  Files         103      103              
  Lines        5313     5314       +1     
==========================================
- Hits         4838     4837       -1     
- Misses        475      477       +2     
Flag Coverage Δ
unittests 91.02% <80.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/neuroconv/tools/testing/mock_interfaces.py 100.00% <100.00%> (ø)
...c/neuroconv/tools/testing/data_interface_mixins.py 95.38% <71.42%> (-0.46%) ⬇️

@CodyCBakerPhD CodyCBakerPhD merged commit 9f27f2e into main Oct 25, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the add_segments_to_mock_recording_interface branch October 25, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants