-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpikeGLX: Add inter-sample shift description and fix ElectrodeGroup naming #1177
base: main
Are you sure you want to change the base?
Conversation
assert device_metadata == expected_device_metadata | ||
|
||
assert test_ecephys_metadata["ElectrodeGroup"] == expected_ecephys_metadata["ElectrodeGroup"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make errors easier to track in the testing suite.
@h-mayorquin this looks great! One comment: I think the name should be Neuropixels instead of Neuropixel, since that's the correct probe name (https://www.neuropixels.org/) |
Ah thanks for the naming thing. It was inconsistent between devices and ElectrodeGroups and I opted for the singular. Thanks for the correction. |
@alejoe91 did the name changing: Neuropixel -> Neuropixels. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
- Coverage 90.69% 90.12% -0.58%
==========================================
Files 129 129
Lines 8189 8300 +111
==========================================
+ Hits 7427 7480 +53
- Misses 762 820 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
|
From the IBL project. The inspector run reveals that the description of inter-sample-shift is missing. As we always have this for SpikeGLX it is a good idea to add it.
Plus, the current ElectrodeGroup naming is confusing when some of the probes have shanks. Here, the diff is illustrative:
Version on main:
Note that the shank number is confusing as they are concatenated with the device number of the probe making it hard to read and identify.
Version on this branch:
In this case, the second and third probes have shanks and the ElectrodeGroups indicate the situation more clearly.