-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ndx-pose>=0.2
for DeepLabCutInterface
and LightningPoseDataInterface
#1128
Conversation
@h-mayorquin, are there any blockers on this? Having this done will help me ensure that the dev tests are fixed properly. |
We are waiting for sleap.io to review the PR: If having this would make your life easier I propose
Or if you have another proposal I am all ears. |
I'm a tad confused bc this PR updates DLC and LightningPose but not sleap. But in general I am in favor of merging what we can, updating the CLI to isolate SLEAP and then we can re-integrate it once the PR is reviewed. |
The PR does not update the code of LightingPos only the one of DLC.
|
Ah, I see. You're just resolving dependency conflicts with LightningPose. Well, even better. We can update DLC in this PR and then LightningPose in the next, adding the appropriate skipifs. Then when all the ndx-pose interfaces are updated we can re-integrate the CI. |
DeepLabCutInterface
DeepLabCutInterface
and LightningPoseDataInterface
talmolab/sleap-io#143 merged! Will ping when we cut a new release. |
Thanks a lot @talmo ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new file with only the pose estimation interfaces.
DeepLabCutInterface
and LightningPoseDataInterface
ndx-pose>=0.2
for DeepLabCutInterface
and LightningPoseDataInterface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions, but otherwise looks good!
Co-authored-by: Paul Adkisson <paul.wesley.adkisson@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
==========================================
- Coverage 90.69% 89.64% -1.05%
==========================================
Files 129 129
Lines 8189 8345 +156
==========================================
+ Hits 7427 7481 +54
- Misses 762 864 +102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This uses the latest release of ndx-pose and modifies the
DeepLabCutInterface
class to use the latest API (e.g. Skeletons instead of nodes).This is related to both:
#1114
and
#1127