Fix codestandards 402 #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
578a395 to
3078a15
Compare
2 tasks
3078a15 to
0a7f7b4
Compare
danmarsden
reviewed
Jul 29, 2024
classes/local/object_manipulator/candidates/candidates_factory.php
Outdated
Show resolved
Hide resolved
danmarsden
reviewed
Jul 29, 2024
classes/local/object_manipulator/candidates/candidates_finder.php
Outdated
Show resolved
Hide resolved
danmarsden
reviewed
Jul 29, 2024
* Re-instate workflow and add initial phpdoc * Add placeholder phpdocs * linting * fix privacy * empty commit to re-run tests * add provider back
0a7f7b4 to
08c0ecf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
MOODLE_402_STABLEwhich fixes things withphpcbfas well as manually fixing unit test data providers