Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for smaller engines, engine block updates #3373

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Content "Allow crafting the smaller engines, make components vary more, destroyed engines drop engine blocks"

Purpose of change

This does some tinkering with stuff pertaining to where engine blocks spawn and how they can be used. Also ended up being some consistency fixes regarding the smaller engines and what parts are implied to be in them.

Describe the solution

  1. Reworked the breaks_into entries for all engines that yield an engine block when uncrafted. Now they drop their engine block, with the extra metal scrap scaled down to compensate for that.
  2. Set it so engine blocks have a chance to spawn in the road and helicopter itemgroups. In each case the weights are taken out of the weights of engines that could spawn there. This makes it so loose engine blocks can be found and potentially tinkered with out on the road.
  3. Added recipes for engines which use tiny and small engine blocks, all of which are reversible. Difficulty, time taken, and tool qualities required are all based on the requirements of the original uncrafts to keep things consistent. Booklearns based off the levels needed to learn the makeshift steam engine recipe.
  4. Remaining engine uncrafts have their difficulty and time requirements bumped up a bit a bit to match the small engine recipes getting a time and difficulty adjustment.
  5. Some adjustments made to engine recipes and uncrafts to make them a bit more meaningfully distinct from each other. Amount of wires scale up with engine block size, cylinder components indicated by a number of pipes added to the recipes scaling with number of cylinders (down to a minimum of one), V-config engines add a chain to the recipe/uncraft (as some diagrams on V-twin and V-6 engines show the use of timing chains), motors removed from 1-cylinder engines (normally scooter engines have starter motors while push mower engines don't, but this helps make the recipes more meaningfully distinct, and it reflects how both engines have an epower of 0), set 1-cylinder engines to require 1 less mechanical pump to represent not having a water pump and being air-cooled.
  6. Misc: Changed 1-cylinder engine item forms to have all of the standard gasoline engine faults EXCEPT faulty starter and water pump as per the above, instead of motors that imply being manually started having the starter motor as their ONLY fault.
  7. Misc: Also removed starter fault from small steam engine, on the basis of it being the only steam engine to have an epower of zero.

Describe alternatives you've considered

  1. Removing 1 mechanical pump from v-twin recipe and removing the water pump fault from it, on the basis that some v-twin engines are also air-cooled.
  2. Or, removing it from the v-twin engine and adding it back to the large 1-cylinder engine on the basis that the large 1-cylinder engine has higher power than the v-twin engine, so is probably more likely to be water-cooled.
  3. Saying "fuck it" and letting you craft any engine that can be taken apart, at ever-escalating levels of mechanics. One side benefit of this is it'd then be feasible to change up and vary the tool requirements even more without it making it excessively complicated to dismantle engines that can't be crafted (mostly because then they'd all be craftable).

Testing

Additional context

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled build to ensure no recipe errors were present.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 6, 2023
@scarf005
Copy link
Member

scarf005 commented Oct 6, 2023

cc @RoyalFox2140

Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image

@scarf005 Looks good to me. Thanks to scarf for spending hours getting CLI working on my desktop. I don't know which vehicles these spawn on so I can't check faults, but they spawn and have recipes.

@chaosvolt chaosvolt added this pull request to the merge queue Oct 7, 2023
Merged via the queue into cataclysmbnteam:upload with commit 4b6cb5b Oct 7, 2023
@chaosvolt chaosvolt deleted the engine-block-stuff branch October 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants