Fix build fail due to REACH_ATTACK flag #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Vollch <544763+vollch@users.noreply.github.com>
How the fuck did it compile without what should be a vital include...
scarf005
approved these changes
Oct 5, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Update use of REACH_ATTACK flag in sdltiles.cpp to fix check failure"
Purpose of change
Fixes an error about incorrect use of
REACH_ATTACKflag that was causing buildbot to scream.Describe the solution
In sdltiles.cpp, added updated
CheckMessagesto fix how theREACH_ATTACKflag is called. Per Volch's advice on the discord, usedSTATICso it doesn't have to be yet another file with flag.h in its includes.Describe alternatives you've considered
Joining the buildbot in the screaming and waiting for someone else to fix it.
Testing
f, nothing weird happened.Real test will be whether the check that was failing passes now.
Additional context