Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainline Stone Chisel #3279

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

RobbieNeko
Copy link
Collaborator

Summary

SUMMARY: Content "Mainlined Stone Chisel from Magiclysm"

Purpose of change

The stone chisel wasn't actually in vanilla BN, with Magiclysm having me totally fooled and thinking it was already in vanilla. I see no good reason for vanilla to only have tools with chiseling 3. This will allow for more variety in chiseling requirements in recipes and constructions. I see no good reason for this to not be a vanilla BN item.

Describe the solution

Adds the stone chisel found in Magiclysm to the list of tools, alongside its recipe. (placed in woodworking due to that being the major use-case I can see)

Describe alternatives you've considered

None

Testing

Made sure the game didn't explode in awe of the stone chisel, and confirmed that it is in fact craftable (after fixing the fact that it explicitly said difficulty 0, which the game didn't like)

Additional context

image

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Sep 27, 2023
@chaosvolt
Copy link
Member

Seems aight, only issue is what would warrant chiseling 1 that isn't already covered by just using cutting quality, I wonder...

@RobbieNeko
Copy link
Collaborator Author

Seems aight, only issue is what would warrant chiseling 1 that isn't already covered by just using cutting quality, I wonder...

A fair question. I will note that, for rocks and similar things that aren't wood (which the chisel (at least by the description) is also intended for.), cutting likely wouldn't be right, but we also wouldn't have a need for the might of chiseling 3.

@RobbieNeko
Copy link
Collaborator Author

Plus, irl there's clearly a reason why chisels are used in woodworking as opposed to merely cutting instruments. Though of course, something being done irl is never necessarily a good argument for doing it in a game. If I had to hazard a guess, I'd posit that chisels allow for better precision.

@RobbieNeko
Copy link
Collaborator Author

I'd think that there are some things you simply can't do whittling for. Such as putting certain notches in things, or carving out only very small sections.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: think up more valid uses for a makeshift chiseling tool. More stone working stuff like the one vanilla example would work.

@RobbieNeko
Copy link
Collaborator Author

Aye, some more stoneworking could definitely work. Or some more complex wood crafts.

@RobbieNeko
Copy link
Collaborator Author

RobbieNeko commented Sep 27, 2023

Plus hey, now it justifies the chiseling requirements I gave the advanced deconstructions I touched a while back xD

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@scarf005 scarf005 added this pull request to the merge queue Sep 27, 2023
Merged via the queue into cataclysmbnteam:upload with commit 5f4e2eb Sep 27, 2023
scarf005 pushed a commit to scarf005/Cataclysm-BN that referenced this pull request Sep 28, 2023
* Mainline Stone Chisel

* Oops, can't have difficulty 0 explicity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants