Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconstructable Sewer pipes & pumps #3112

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

RoyalFox2140
Copy link
Collaborator

Summary

SUMMARY: [Balance] "Sewage pipes and pumps are deconstructable into their bash products"

Purpose of change

Sewer pipes and sewer pumps have no deconstruct, but they're just steel with some pipe fittings, so this lets you deconstruct them.

Describe the solution

I used the exact bash products to be safe. If we should up the steel amount I leave that to a maintainer to balance as this is going to add a lot of steel platings in the sewers now. I also set the deconstruct terrain to the bridges in the sewers as you're not bashing the pipe to scrap so it should maintain structural integrity underneath.

This gives you more reason to go into sewers and allows us to put these sewer connections in the way of building basements for urban development but still let you access the sewers with just tools and not bashing or mining. This source of steel shouldn't be too powerful as so much other stuff gives tons of steel including car wrecks.

Describe alternatives you've considered

More Steel. Less Steel. Hacksaw instead. Keeping them mineable even though that is horrible.

Testing

Loaded in game and both deconstructs worked as expected.

Additional context

image

Pipes are set to be deconstructible and give their bash products. Uses sewer bridges for the terrain as deconstruction is more delicate than smashing.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Sep 1, 2023
aaaa

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@olanti-p
Copy link
Contributor

olanti-p commented Sep 1, 2023

You can lint the changes locally by dragging the changed .json file over the json_formatter.exe (shipped with every release of the game), or by running make style-json if you're using linux/cygwin/msys2.

@RoyalFox2140
Copy link
Collaborator Author

You can lint the changes locally by dragging the changed .json file over the json_formatter.exe (shipped with every release of the game), or by running make style-json if you're using linux/cygwin/msys2.

I just figured it was right since I was following the other deconstructs and it was such a small addition. Didn't realize two product deconstructs wanted to be on the same line as that stretches out so far.

@chaosvolt
Copy link
Member

High-pressure pumps may also be a potential deconstruct return worth adding, too.

@RoyalFox2140
Copy link
Collaborator Author

RoyalFox2140 commented Sep 1, 2023

High-pressure pumps may also be a potential deconstruct return worth adding, too.

image
This one? EDIT: CV Meant the Item. High pressure pump item has no craft uses and can't be deconstructed.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, checked and turns out the sole vanilla use for high-pressure pumps it is obscure and almost never a factor (mending faulty fuel pumps in diesel engines), so this should be fine as-is.

@chaosvolt chaosvolt merged commit 08c6dba into cataclysmbnteam:upload Sep 1, 2023
@RoyalFox2140 RoyalFox2140 deleted the sewage-pipe-bonanza branch September 17, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants