Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract to vehicle_part.h #3104

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Aug 31, 2023

Summary

SUMMARY: Infrastructure "Separate vehicle.h with vehicle_part.h"

Purpose of change

vehicle.cpp and vehicle_part.cpp are already separated, doing the same for headers make sense as it means less chance to recompile everything (in the future)

Describe the solution

cut and pasted vehicle_part class into vehicle_part.h.

Testing

built without errors on my machine.

@github-actions github-actions bot added src changes related to source code. tests changes related to tests labels Aug 31, 2023
@scarf005 scarf005 marked this pull request as draft August 31, 2023 03:23
@scarf005 scarf005 force-pushed the extract-vehicle-part branch from 73fc274 to 4c91a35 Compare August 31, 2023 03:33
@scarf005 scarf005 marked this pull request as ready for review August 31, 2023 13:35
@scarf005 scarf005 force-pushed the extract-vehicle-part branch from 4c91a35 to 5ca3e4b Compare September 1, 2023 02:29
@scarf005 scarf005 force-pushed the extract-vehicle-part branch from 5ca3e4b to d1b5233 Compare September 16, 2023 23:42
@scarf005 scarf005 requested a review from olanti-p September 16, 2023 23:42
Copy link
Contributor

@olanti-p olanti-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like many .cpp files don't necessarily need including vehicle_part.h, but that can be fixed later by iwyu.

@scarf005 scarf005 merged commit 5e0d092 into cataclysmbnteam:upload Sep 18, 2023
@scarf005 scarf005 deleted the extract-vehicle-part branch September 18, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants