Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merchant price-fix for .223 magazines and two bionics #3093

Merged

Conversation

borsek
Copy link
Contributor

@borsek borsek commented Aug 27, 2023

Summary

Content: "Merchant price-fix for .223 magazines and two bionics."

Purpose of change

Some .223 magazines were missing price_postapoc and were selling for absurd amounts compared to their more useful counterparts.

Same goes for bionics, though I'm unsure if these prices were left as flavour - let me know.

Describe the solution

Added appropriate lines to the .json files.

Describe alternatives you've considered

This might be intended, at least on the bionic front - considered leaving it as is. Alternatively, the Bionics could do with a thorough check and each having its own price. Let me know.

Testing

Went to merchant, spawned relevant items, checked prices.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Aug 27, 2023
@@ -1295,7 +1294,6 @@
"name": { "str": "Dopamine Stimulators CBM" },
"description": "A set of tiny bionic nerve stimulators that install into the reward center of your brain. When run with bionic power, it periodically releases a hit of dopamine and other reward chemicals, inducing a state of euphoria and suppressing fear.",
"price": 1000000,
Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Price one digit higher that other CBMs. Probably typo. Reduce it from
1000000
to
100000

Co-authored-by: scarf <greenscarf005@gmail.com>
Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@Firestorm01X2 Firestorm01X2 merged commit 47413e1 into cataclysmbnteam:upload Aug 28, 2023
@borsek borsek deleted the pricefixes-20rd-40rd-ling branch September 16, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants