-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PARROT_AT_DANGER attack, proper quotes for new feral lines #2837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should change parrot_common to auto-wrap speech in quotation mark
Problem is some parrot lines are descriptive instead of a quote, like |
oh, alright in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
SUMMARY: Bugfixes "PARROT_AT_DANGER monster attack can now be triggered when targeting the player, added quotation marks to new feral speech lines."
Purpose of change
Dumb thing I forgot in #2809 hecc
In addition, a side effect of this is Scarf discovered that PARROT_AT_DANGER doesn't work if the monster is after the player, they can only see monsters it seems.
Describe the solution
mattack::parrot_at_danger
to actually check for if target of the monster has a target they're after (and not a hacky-as-fuck-looking check of all monsters), then if it has a valid target it can see proceeding with the parrot attack.Describe alternatives you've considered
Screaming "I am the night rider!" at the code until it fixes itself for me.
Testing
Additional context