Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: buff all water purification methods by 8x (250ml -> 2L) #2832

Merged
merged 1 commit into from
May 16, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented May 16, 2023

Summary

SUMMARY: Balance "Buff all water purification methods by 8x (250ml -> 2L)"

Purpose of change

rationale:

  1. water purification tablets are too inefficient
  2. google says a single tablet can purify up to 1~2L of water

Each tablet treats up to 2 quarts of clean water or 0.8 quart of dirty water
ew, US measurements but that's not the point

Describe the solution

modified charges used in iuse::water_purifier by 1/8

Testing

2023-05-16.11-26-57.mp4
using single tablet
  1. spawn a 3L bottle, a bottle (0.5L), and 2 water purification tablet
  2. fill the bottles with water
  3. use tablets to each bottles
  4. check that both are purified
2023-05-16.11-47-46.mp4
using multiple tablets
  1. spawn a 10L jerrycan, and 5 water purification tablet
  2. fill the jerrycan with water
  3. use tablet
  4. check that the jerrycan is purified, and all tablets are used

rationale:
1. water purification tablets are too inefficient
2. google says a single tablet can purify up to 1~2L of water
ew, US measurements but that's not the point: https://www.rei.com/product/109906/aquatabs-water-purification-tablets-package-of-30
@scarf005 scarf005 requested a review from chaosvolt May 16, 2023 02:43
@github-actions github-actions bot added JSON related to game datas in JSON format. src changes related to source code. labels May 16, 2023
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Airing on the side of 1 liter instead of 2 liter would also work, but whichever you prefer I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants