Separate starting battery from mechs #2831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Spawn mech battery separate from the mech, allowing for mechs to be placed without a power cell when needed"
Purpose of change
Set this change aside separate from #2829 so it doesn't bog the other stuff down or vice-versa.
This is aimed specifically at making it less of a pain in the ass to add support for mechs that can be spawned via a
place_monster
item. Presently not useful in vanilla but it could be in the future, out of repo it's useful for Arcana.Describe the solution
monster::monster
so that mechs don't spawn with a battery pre-loaded.The reason for this is, if you have a source of the monster from an item, there's the possbility that it may have been crafted or otherwise loaded, such that the player is well aware how charged the battery that went into it is. As such, having it spawn with a random amount of battery power in this instance is a mere annoyance, and it'd be better to have the player provide the power cell separately after getting the mech up and running.
I would've wanted to have this only take effect if the mech spawns with the pet flag, to cover the above issues, but pet flag application from
place_monster
items presumably takes effect after the monster generates its starting battery, so this doesn't work. As such, because this removes the starter battery from all mechs...Describe alternatives you've considered
Spawning mech cells in these spawns with set amounts of charge, or even just grant full ones outright.
Testing
Additional context