Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large grid battery using wrong looks_like #2825

Merged
merged 1 commit into from
May 14, 2023

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Bugfixes "Set largest grid battery to look like a battery, not a locker."

Purpose of change

Random find I stumbled into that I could've fucking sworn I fixed, but evidently not.

Describe the solution

Changed looks_like of large storage battery furniture to use the same standard battery as its target, not lockers.

Describe alternatives you've considered

Going insane because I could've sworn I fixed this twice, and I can confirm visually what the exact problem is, so I dunno how I could've failed to fix it twice.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Spawned in and confirmed big battery now looked like the other batteries.

image

Additional context

@chaosvolt chaosvolt enabled auto-merge (squash) May 14, 2023 04:45
@github-actions github-actions bot added the JSON related to game datas in JSON format. label May 14, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondered if it was intentional, turns out it wasnt

@chaosvolt chaosvolt merged commit de0fabf into cataclysmbnteam:upload May 14, 2023
@chaosvolt chaosvolt deleted the batteries-go-nyoom branch May 14, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants