Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix targeting"
Purpose of change
Fixes #2567.
Issue was that there's a Character variable and Player variable
last_target
andlast_target_pos
, so inaim_activity_actor::finish()
the game was checking the wrong variable and resetting the wrong variable.Describe the solution
Remove unused Character variables
last_target
andlast_target_pos
. Fix consideration inaim_activity_actor::finish()
so it'll check and update correct variable.Describe alternatives you've considered
save_game_json.cpp
and would probably be better as part of a Player to Character migration.Testing
Spawn 5 decayed zombies and wield an M4A1. Save
Additional context