Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab Finale Rework #2759

Merged
merged 8 commits into from
May 15, 2023
Merged

Lab Finale Rework #2759

merged 8 commits into from
May 15, 2023

Conversation

MrLostman
Copy link
Contributor

@MrLostman MrLostman commented May 4, 2023

Summary

SUMMARY: Content "reworks lab endings into two pools that it picks two from to create a finale & json's all hard coded endings"

Purpose of change

With the size of the lab finale pool and the amount of finales that either didn't have anything at all for the player or only useful for very specific characters this often made lab finales a not very rewarding experience that quickly turned into a grind. This is very pronounced in things like getting nano material.

Describe the solution

By breaking up the pool of finales between objects of interest and pure loot finales then picking one from each pool this cuts the total pool in half. This has the effect of reducing the chance of a player getting nothing they are interested in significantly lower.

The change also removes mutagen tank ending & buffs advanced mutagen ending by going from 1 -> 4 mutagen and always 1 smart purifier.

Describe alternatives you've considered

Buffing each ending itself, but that would have the problem of pool dilution.

Testing

Teleporting into lab finales and checking the mapping and loot drops

Additional context

CaptureC

CaptureD

CaptureB

CaptureA

@github-actions github-actions bot added JSON related to game datas in JSON format. src changes related to source code. labels May 4, 2023
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Compiled and load-tested.
  2. Started lab escape scenario several times, picking deep freeze and lab finale to take a look at what was there.
  3. It found the lab finale and spawned in correctly each time, so mapgen changes seem to work fine.
  4. After fixing an amusing issue where turrets in two finale variants spawned on toilets, every other layout had no problems as far as I could tell.

@chaosvolt chaosvolt merged commit 70db814 into cataclysmbnteam:upload May 15, 2023
chaosvolt added a commit to chaosvolt/cdda-arcana-mod that referenced this pull request May 16, 2023
@MrLostman MrLostman deleted the lab-finale-rework branch May 18, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants