Allow repairing items with forges #2188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Add item repair use action to charcoal forges, electric forges, and grid forge fake item."
Purpose of change
Something I'd wanted for years but only realized I could implement while working on #2187. This is basically why can forges in Cataclysm++ have a use action, because for the longest time you couldn't have forges do repair actions without it causing weird behavior with the furniture version.
Describe the solution
use_furn_fake_item
examine to grid forges.Describe alternatives you've considered
Testing
One problem with this however: far as I'm aware, examine_action can't currently be an array, so charcoal forge furniture can't have both
use_furn_fake_item
andreload_furniture
, meaning only its item form can be used for repairs.Stuff like braziers can handle undeploying from
deployed_item
automatically, freeing up its examine action to count as a fireplace. Maybe I could look into the code to see if there's some way to handleuse_furn_fake_item
stuff automatically, or would convertingexamine_action
into an array be a more desirable fix?Additional context
Per testing in the linked PR above, being able to activate grid forges to repair items should correctly carry over to grid forge rigs.