Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easier installing/removing of some parts #2154

Merged
merged 2 commits into from
Nov 26, 2022

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Nov 2, 2022

Summary

SUMMARY: Balance "Allow installing or removing a wider range of lighter vehicle parts with level 1 tool qualties"

Purpose of change

This seeks to add a wider variation to the tool usage for installing and removing parts on a vehicle, with the added goal of making it possible to potentially get sheet metal and the occasional frame out of vehicles with level 1 tool qualities.

Describe the solution

  1. Boards, quarterpanels, and roofs that return sheet metal or pipes set to allow level 1 metal sawing to remove instead of level 2. Level 2 quality stays for heavier panels and the like.
  2. Wire baskets set to allow level 1 sawing to remove instead of level 2, except for lighter baskets that already used just screwdriving quality.
  3. 1-cylinder scooter engines set to allow level 1 bolt turning to install and remove instead of level 2. Larger engines left unchanged.
  4. Basic doors and trunk doors set to require level 1 bolt turning quality to remove, instead of level 2. Install requires level 2, per feedback. Heavy-duty doors, opaque doors, and hatches retain use of level 2 quality.
  5. Small makeshift pallet lifters set to allow level 1 bolt turning quality to install and remove, leaving the heavier engineering parts to retain level 2 quality and/or welding.
  6. Motorbike kickstands set to allow level 1 metal sawing to remove, instead of level 2.
  7. Foldable light frames, extra light frames, and cart handles set to allow level 1 metal sawing to remove, instead of level 2. Regular frames and heavier remain unchanged.
  8. Aisles and lit aisles set to allow level 1 metal sawing to remove, instead of level 2. Heavier aisles level unchanged.
  9. Foot pedals and hand rims set to allow level 1 bolt turning to install and remove, instead of level 2.
  10. Saddles set to allow level 1 bolt turning to install and remove, instead of level 2. Standard seats left unchanged for now.
  11. 10-liter tanks, being made from plastic jerrycans, set to allow level 1 drilling to install instead of level 2.
  12. Mufflers set to allow level 1 metal sawing to remove, instead of level 2.
  13. Metal funnels set to allow level 1 metal sawing to remove, instead of level 2.
  14. Light wheel mounts set to level 1 metal sawing to remove. Unicycle/bicycle/tricycle wheels, wheelchair wheels, wheelbarrow wheels, motorcycle wheels, small wheels, and casters set to allow level 1 bolt turning to remove, instead of level 2. Basically stuff that related to light wheel mounts or no mount needed. Medium+ mounts, regular wheels, and the like left unchanged.

Describe alternatives you've considered

  1. Allowing basic seats and/or trunks to be removable with level 1 bolt turning. The thought that came to mind was mostly that it would involve more working with tight spaces compared to just opening a vehicle door and getting at bolts in the hinge.
  2. Allowing non-hd opaque doors and/or shutter doors to be removable with level 1 bolt turning. Could go either way, wasn't sure if it should logically be more fiddly or not, but for now it was mostly just on the basis of restricting access to the generally-more-durable door types to level-2 qualities.
  3. Allowing windshields to be removable with level 1 metal sawing.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Ported file changes to recent release and tested in-game.

Tested before and after, trying to strip down as many parts as possible from a bog-standard car with level 3 mechanics and a multi-tool.

Before:
before

After:
after

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 2, 2022
@Coolthulhu Coolthulhu self-assigned this Nov 15, 2022
@Coolthulhu
Copy link
Member

Overall good, but I'd keep door installation at "tier 2". Just installation.

@Coolthulhu Coolthulhu merged commit 36bd4a6 into cataclysmbnteam:upload Nov 26, 2022
@chaosvolt chaosvolt deleted the easier-part-removal branch November 26, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants