Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo on modinfo.json schema #2029

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix typo on modinfo.json schema #2029

merged 1 commit into from
Oct 20, 2022

Conversation

scarf005
Copy link
Member

Summary

SUMMARY: Bugfixes "fix typo on modinfo.json schema"

Purpose of change

conflics -> conflicts

@scarf005
fix: typo on modinfo.json schema
c0c232d 
conflics -> conflicts
@Coolthulhu Coolthulhu self-assigned this Oct 15, 2022
@Coolthulhu Coolthulhu merged commit c0dcb87 into cataclysmbnteam:upload Oct 20, 2022
@Coolthulhu
Copy link
Member

Do we have a good way of auto-checking those?

@scarf005
Copy link
Member Author

scarf005 commented Oct 20, 2022 •
edited
Loading

some way i could think of is:

  1. make those example a separate file
  2. use JSON schema to validate invalid field
  3. use static site generator (e.g.: mkdocs) to import code snippet and render them

@scarf005 scarf005 deleted the patch-3 branch October 25, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Coolthulhu Coolthulhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scarf005 @Coolthulhu