Debug menu can look across z levels and reset ignored messages #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coolthulhu
reviewed
Oct 20, 2022
| @@ -370,7 +372,7 @@ static int debug_menu_uilist( bool display_all_entries = true ) | |||
|
|
|||
| void teleport_short() | |||
| { | |||
| const cata::optional<tripoint> where = g->look_around(); | |||
| const cata::optional<tripoint> where = g->look_around( true ); | |||
There was a problem hiding this comment.
This one is great, I wasted a ton of time "emulating" it by switching 3D fov on just for one teleport.
Coolthulhu
reviewed
Oct 20, 2022
| return result.position; | ||
| } | ||
|
|
||
| look_around_result game::look_around( bool show_window, tripoint ¢er, | ||
| const tripoint &start_point, bool has_first_point, bool select_zone, bool peeking, | ||
| bool is_moving_zone, const tripoint &end_point ) | ||
| bool is_moving_zone, const tripoint &end_point, bool force_3d ) |
There was a problem hiding this comment.
That signature got really ugly. 5 bool parameters mean it is trying to do many different things at once and isn't very general.
In the future, it will need a refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "The debug menu can look across z levels and reset ignored messages"
Purpose of change
The various tile selection things in the debug menu no longer respect the 3d vision settings. They always let you select any z level. There's also an additional option under the info menu that clears the list of ignored debug messages.
Describe the solution
look_around has gained a bool to force the full 3d range and there's a new menu option that clears the ignored list.
Describe alternatives you've considered
None really.
Testing
I checked looking around with fov_3d and z levels on and off and resetting works on the message you can generate in the debug menu.