Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicates in item view #1994

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

joveeater
Copy link
Collaborator

Summary

SUMMARY: Bugfixes "Prevent duplicates in the item view when 3d vision is on"

Purpose of change

No more duplicates.

Describe the solution

Better math on the iteration over z levels, it was doing 0 twice.

@olanti-p
Copy link
Contributor

There seems to be an off-by-one error somewhere.

Repro steps:

  1. Set Vertical range of 3D field of vision to 1
  2. Spawn as the default evacuee in a refugee shelter
  3. Drop a knife near the entrance
  4. Climb on the rooftop
  5. You can see the knife when in "Look around" mode (x)
  6. Open V, see the knife is not there

@joveeater
Copy link
Collaborator Author

Yep, right you are. It was missing the lowest z level.

@Coolthulhu Coolthulhu self-assigned this Oct 11, 2022
@Coolthulhu Coolthulhu merged commit 3b88e28 into cataclysmbnteam:upload Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants