Fix bash spells doing nothing to walls and windows #1949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Trivial bugfix for bash spell effect not working against impassible terrain"
Purpose of change
This fixes a long-running bug that @foulman reported in DDA ages ago: CleverRaven/Cataclysm-DDA#38077 in which bash spells do absolutely nothing to solid terrain like doors, walls, or even windows.
Turns out, the code for it is immensely, hilariously easy to fix. As in, the sort of thing @KorGgenT could've fixed over 2 years ago with literally just the flip of a single boolean.
Describe the solution
Literally just set the ignore_walls boolean in
area
defintion forspell_effect::bash
to true.Describe alternatives you've considered
Pestering someone else to do it.
Testing
Additional context
This will allow me to remove the "ter_transform subspells as a workaound" hack I've been using to deal with this for Arcana's bash spell effects.
Ideally if we get someone to port this to DDA that'd be nice.Tested and it looks like somehow their version of spell shape code properly bashes walls if it hasIGNORES_WALLS
, so it's actually fixed on their end but no one took notice of it.