Add exact match search in debug spawns and fix duplicated debug key #1936
Conversation
src/ui.cpp
Outdated
| @@ -222,9 +222,19 @@ void uilist::filterlist() | |||
|
|
|||
| int f = 0; | |||
| int num_entries = entries.size(); | |||
| // check if string begin by " and finish by ". If that's the case, we only return a result if it matches it exactly | |||
| bool exactMatchOnly = filter.front() == '\"' && filter.back() == '\"'; | |||
There was a problem hiding this comment.
What if filter is empty?
There's a check on line 216 that implies the filter string may be empty, so calling filter.front() or filter.back() would result in undefined behavior (i.e. a crash on some systems).
There was a problem hiding this comment.
If you go see the code of .front() and .back(), they have an internal check on empty strings (which is why I never crashed even when testing those).
Still I added an extra check in case this line is modified later.
There was a problem hiding this comment.
they have an internal check on empty strings
I'm looking into MSVC's implementation of .front(), and there are checks, except they're skipped in Release build, so essentially you're comparing " with some random byte in the memory, and get a false result 255 times out of 256.
On Debug build, the checks are present and working
I ought to omit my own statements regarding preferring Release builds where possible...
There was a problem hiding this comment.
Ah! Then good catch indeed
|
Why those both in single PR? |
|
I think that's okay, since those two are related (debug) and being only a 16 line edit |
Summary
SUMMARY: Content "Add exact match search in debug spawns and fix duplicated debug key"
Purpose of change
fix duplicated debug key
The fix is quite simple, you couldn't use the "S" key to change your stamina through the debug menu because the "Learn all Spells" functionality used the same key
add exact match search in debug spawns
The debug search menu use a "search substring in string" system, which can be annoying when you type the full name of an item and still get the wrong item as first choice.
Describe the solution
fix duplicated debug key
I rebinded some keys so all debug functionalities can be accessed through shortcuts.
add exact match search in debug spawns
Most of the time this system is fine. So I added an optionnal way to search for exact match when using double quotes like this -> "example" (very popular system, exist in most web browsers)
Cf example below.
By default, searching for 'sledge hammer' would give you 'heavy sledge hammer' by default, or one of the three if you had selected one of the results before.
Well now you can search for "sledge hammer" and be 100% sure to get what you asked.
Testing