Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double to int for debug message #1798

Merged

Conversation

KheirFerrum
Copy link
Collaborator

Summary

SUMMARY: Bugfix "Make debug message for lift_thrust print properly"

Purpose of change

Debug message for lift_thrust couldn't print because it was trying to taking an int for a float conversion.

Describe the solution

Changes from float to int in the debug message.

Describe alternatives you've considered

Testing

Spawned atomic helicopter, turned on debug mode and started the vehicle, debug message displays properly.

Additional context

I know that lift is now displayed correctly, but the math is still a bit of a headache for me.

@KheirFerrum KheirFerrum force-pushed the Fix-lift_thrust-debug-message branch from 46a3977 to ffb5f00 Compare August 22, 2022 16:28
@KheirFerrum KheirFerrum force-pushed the Fix-lift_thrust-debug-message branch from ffb5f00 to 28c690b Compare August 22, 2022 21:19
Copy link
Contributor

@olanti-p olanti-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codebase is mostly leaning towards using %d, not %i, but our formatter handles both the same way, so it's just a nitpick on my part.

@olanti-p olanti-p merged commit 9acb13f into cataclysmbnteam:upload Aug 25, 2022
@KheirFerrum KheirFerrum deleted the Fix-lift_thrust-debug-message branch August 28, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants