Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killer drive spam clearance #1718

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Conversation

Krwak
Copy link
Contributor

@Krwak Krwak commented Jul 12, 2022

Summary

SUMMARY: [None] "Have killer drive inform about the withdrawal only once"

Purpose of change

Killer drive trait was informing player every 4 hours about the need to kill more monsters, giving random snippet from a list.
This is rather irritating after a while and is spamming the player.

Describe the solution

Changed the code in suffer.cpp so that it won't spam the player anymore. Code written by Kheir.
Game will check only once if there is a withdrawal and inform the player about it only once.

Describe alternatives you've considered

Delete the snippets from json file.

Testing

Compiled the game with the change, opened the game and made a new character with killer drive trait.
Killed a few zombies and then waited for a day to see how many snippets will the game offer.
The game offered only one snippet after 4 hours.
Tried this more times.

Additional context

Krwak added 4 commits July 12, 2022 09:22
Have killer drive not spam player each 4 hours if they don't kill anyone.
This reverts commit 8b788c3.
@Coolthulhu Coolthulhu self-assigned this Jul 18, 2022
@Coolthulhu
Copy link
Member

Killer Drive morale stacking doesn't seem to be working. I waited a whole day and it's at -1.
The spam stopped happening, but I'd need a separate test to tell if it was broken or got broken here.

@Coolthulhu
Copy link
Member

I tested it in mainline and it looks like the penalty is broken in both.

@Coolthulhu Coolthulhu merged commit 002e131 into cataclysmbnteam:upload Aug 15, 2022
@Krwak Krwak deleted the Killer_drive_spam branch September 24, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants