Magazine Weight Fix #1707
Merged
Magazine Weight Fix #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Magazine weight was not being added to items with a magazine."
Purpose of change
Fixes #1677.
Describe the solution
Item weight code lacked a check for whether an item had a magazine, and thus did not add the relevant weight to the gun.
Describe alternatives you've considered
Ignore for another 2 months
Testing
Spawn M4A1, 10 round STANAG magazine and SIG 552. Record all weights, unload both bullets and magazines from all 3. Checked both guns without magazine, with empty magazine, and with full 10 round STANAG magazine. Confirmed numbers are as expected.
Additional context